Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove NS0 hardcoded optimization #2320

Merged
merged 2 commits into from Jan 8, 2019
Merged

CI: Remove NS0 hardcoded optimization #2320

merged 2 commits into from Jan 8, 2019

Conversation

Pro
Copy link
Member

@Pro Pro commented Dec 21, 2018 •
edited

Remove hardcoded optimization level for NS0 file. Fixes #2315

This is for now a test to see how fast everything compiles.

@Pro Pro mentioned this pull request Dec 21, 2018
Closed
@Pro Pro self-assigned this Jan 3, 2019
@Pro Pro force-pushed the test_ns0_optimization branch 2 times, most recently from 3a354be to 6099c2a Compare January 4, 2019 14:04
@Pro Pro changed the title [WIP] CI: Remove NS0 hardcoded optimization CI: Remove NS0 hardcoded optimization Jan 4, 2019
@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited

Coverage Status

Coverage decreased (-0.008%) to 84.693% when pulling 5ce6a59 on test_ns0_optimization into 7511883 on master.

@Pro Pro force-pushed the test_ns0_optimization branch 3 times, most recently from d76ed9b to 0269345 Compare January 8, 2019 08:17
@codecov
Copy link

codecov bot commented Jan 8, 2019 •
edited

Codecov Report

Merging #2320 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
- Coverage   84.92%   84.91%   -0.01%     
==========================================
  Files         112      112              
  Lines       25350    25350              
==========================================
- Hits        21529    21527       -2     
- Misses       3821     3823       +2
Impacted Files Coverage Δ
src/server/ua_securechannel_manager.c 74.3% <0%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7511883...5ce6a59. Read the comment docs.

@Pro Pro merged commit f16afc7 into master Jan 8, 2019
@Pro Pro deleted the test_ns0_optimization branch January 8, 2019 12:11
@Pro Pro mentioned this pull request Jan 9, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Pro Pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting O0 for ua_namespace0.c not appropriate
2 participants
@Pro @coveralls