New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodestore: Use zip tree instead of hashmap for the nodestore #2328

Merged

Pro merged 1 commit into master from zip_nodestore

Dec 28, 2018

Member

jpfr commented Dec 27, 2018

The nodestore is a lot cleaner now.
Using the same datastructure in several places reduces cognitive overhead
Small speed improvements on by box


          Nodestore: Use zip tree instead of hashmap for the nodestore

74f727c

coveralls commented Dec 27, 2018

Coverage decreased (-0.1%) to 84.883% when pulling 74f727c on zip_nodestore into f97c524 on master.

jpfr requested a review from Pro

December 27, 2018 15:47

Pro approved these changes

View reviewed changes

Pro merged commit f718d55 into master

Pro deleted the zip_nodestore branch

December 28, 2018 08:07

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.