Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Add warning if fuzzing build is enabled #3514

Merged
merged 1 commit into from Apr 9, 2020
Merged

Conversation

Pro
Copy link
Member

@Pro Pro commented Mar 17, 2020

If UA_BUILD_FUZZING authentication tokens and other variables are overridden internally. This causes subscriptions and other parts of the code to not work as expected.

Since UA_BUILD_FUZZING should not be used for debug or release builds in general, show a warning to avoid accidental usage of this build option.

@Pro Pro added Type: Enhancement Describes a feature request or addition of new functionality Priority: Low Issue with low priority Component: Core Issues related to the core code Status: Merge When Green Merge PR when CI is green labels Mar 17, 2020
@jpfr
Copy link
Member

jpfr commented Apr 9, 2020

Rebased.

@jpfr jpfr merged commit 1bbcdcb into master Apr 9, 2020
@jpfr jpfr deleted the fix/warn_fuzz branch April 9, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Issues related to the core code Priority: Low Issue with low priority Status: Merge When Green Merge PR when CI is green Type: Enhancement Describes a feature request or addition of new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants