fix(PubSub): fix order of SecurityHeader and ExtendedNetworkMessageHe… #5979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves issue #5978 |
|
Is this also valid for 1.3? If yes, please rebase and we merge upwards from there. |
keba-estr
force-pushed
the
feature/fix_header_order
branch
from
a5b5a5e
to
217fe9a
Compare
keba-estr
force-pushed
the
feature/fix_header_order
branch
from
217fe9a
to
700ffca
Compare
Yes, this also was a problem on the 1.3 branch. I rebased the feature branch to 1.3. |
…ader In the PubSub specification the SecurityHeader is before the ExtendedNetworkMessageHeader, thus the headers must be decoded in this order.
keba-estr
force-pushed
the
feature/fix_header_order
branch
from
700ffca
to
7730e6f
Compare
|
@jpfr: CI on 1.3 fails. Is this the correct branch? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ader
In the PubSub specification the SecurityHeader is before the ExtendedNetworkMessageHeader, thus the headers must be decoded in this order.