Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate Server::setAccessControl by reference #234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lukasberbuer
Copy link
Member

The lifetime of the access control instance can not be controlled and the reference might become dangling.
Use following overload instead:

void Server::setAccessControl(std::unique_ptr<AccessControlBase> accessControl)  // transfer ownership to server

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (4dc7590) to head (fb8a040).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   85.19%   85.08%   -0.12%     
==========================================
  Files          80       80              
  Lines        4351     4351              
  Branches     1745     1745              
==========================================
- Hits         3707     3702       -5     
- Misses        202      206       +4     
- Partials      442      443       +1     
Flag Coverage Δ
Linux 85.08% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant