Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Variant::isArray check #274

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Variant::isArray check #274

merged 1 commit into from
Apr 8, 2024

Conversation

lukasberbuer
Copy link
Member

Failed if array is empty.

Failed if array was empty
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.72%. Comparing base (7f51d36) to head (3d01ec6).

Files Patch % Lines
include/open62541pp/types/Variant.h 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   84.75%   84.72%   -0.04%     
==========================================
  Files          80       80              
  Lines        4212     4216       +4     
  Branches      943      943              
==========================================
+ Hits         3570     3572       +2     
- Misses        172      173       +1     
- Partials      470      471       +1     
Flag Coverage Δ
Linux 84.72% <88.88%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasberbuer lukasberbuer merged commit acad65d into master Apr 8, 2024
70 of 71 checks passed
@lukasberbuer lukasberbuer deleted the fix/variant-isarray branch April 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant