3dconnexion: SpaceMouse Pro support added #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support to Ctlra for the SpaceMouse Pro. The wireless version of the device was used for testing, although it is expected to be similar to the wired version. All input buttons are mapped to Ctlra events, and the 6-dof knob controller is mapped to 12 sliders as follows: - Move Left - Move Right - Move Forward - Move Backward - Move Up - Move Down - Rotate Anti-Clockwise - Rotate Clockwise - Rotate Left - Rotate Right - Rotate Backward - Rotate Forward. Combining two axis back into a single -1..1 range value is trivial in the application, if the application wants to use that range. Signed-off-by: Harry van Haaren <harryhaaren@gmail.com>
foolswood
reviewed
Oct 19, 2017
| (void)future; | ||
| struct spacemouse_t *dev = calloc(1, sizeof(struct spacemouse_t)); | ||
| if(!dev) | ||
| goto fail; |
There was a problem hiding this comment.
This is the only goto fail, but there are 3 instances of the code of fail in this function.
There was a problem hiding this comment.
Fixed, thanks for review!
ctlra/devices/3dconnexion.c
Outdated
| uint8_t *buf = data; | ||
|
|
||
| switch(size) { | ||
| case 7: |
Thanks for the review! Signed-off-by: Harry van Haaren <harryhaaren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to Ctlra for the SpaceMouse Pro.
The wireless version of the device was used for testing,
although it is expected to be similar to the wired version.
All input buttons are mapped to Ctlra events, and the 6-dof
knob controller is mapped to 12 sliders as follows:
Combining two axis back into a single -1..1 range value is trivial
in the application, if the application wants to use that range.
Signed-off-by: Harry van Haaren harryhaaren@gmail.com