issue-293 introduced eslint + husky + lint-staged and fixed major errors

.github/workflows/eslint.yaml

@@ -0,0 +1,28 @@
+name: Run eslint
+
+on:
+  pull_request:
+    branches:
+      - develop
+
+jobs:
+  eslint:
+    name: Run eslint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
+      - name: Install dependencies
+        run: npm install
+        working-directory: server
+
+      - name: Run ESLint
+        run: ./node_modules/.bin/eslint .
+        working-directory: server

server/.eslintrc.json

@@ -0,0 +1,25 @@
+{
+  "env": {
+    "commonjs": true,
+    "es2021": true,
+    "node": true
+  },
+  "extends": "eslint:recommended",
+  "parserOptions": {
+    "ecmaVersion": "latest"
+  },
+  "rules": {
+    "no-async-promise-executor": "off"
+  },
+  "overrides": [
+    {
+      "files": [
+        "**/*.spec.js",
+        "**/*.test.js"
+      ],
+      "env": {
+        "jest": true
+      }
+    }
+  ]
+}

server/.husky/pre-commit

@@ -0,0 +1,7 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+SERVER_DIR=$(dirname -- "$0")/..
+# change working dir to be server/
+cd $SERVER_DIR
+npx lint-staged

server/.lintstagedrc.json

@@ -0,0 +1,5 @@
+{
+  "*.js": [
+    "eslint"
+  ]
+}

server/controllers/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "no-unused-vars": "off"
+  }
+}

server/controllers/GenericResponseProfile.js

@@ -3,7 +3,7 @@
 var GenericResponseProfile = require('../service/GenericResponseProfileService');
 var responseBuilder = require('onf-core-model-ap/applicationPattern/rest/server/ResponseBuilder');
 var responseCodeEnum = require('onf-core-model-ap/applicationPattern/rest/server/ResponseCode');
-var oamLogService = require('onf-core-model-ap/applicationPattern/services/OamLogService');;
+var oamLogService = require('onf-core-model-ap/applicationPattern/services/OamLogService');
 
 module.exports.getGenericResponseProfileDatatype = async function getGenericResponseProfileDatatype (req, res, next, uuid) {
   let responseCode = responseCodeEnum.code.OK;

server/controllers/HttpClient.js

@@ -3,7 +3,7 @@
 var HttpClient = require('../service/HttpClientService');
 var responseBuilder = require('onf-core-model-ap/applicationPattern/rest/server/ResponseBuilder');
 var responseCodeEnum = require('onf-core-model-ap/applicationPattern/rest/server/ResponseCode');
-var oamLogService = require('onf-core-model-ap/applicationPattern/services/OamLogService');;
+var oamLogService = require('onf-core-model-ap/applicationPattern/services/OamLogService');
 
 module.exports.getHttpClientApplicationName = async function getHttpClientApplicationName(req, res, next, uuid) {
   let responseCode = responseCodeEnum.code.OK;