Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMT v10.2.1 compatibility #9

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Unsttopabull
Copy link
Contributor

No description provided.

@NikolaiShipilov
Copy link
Collaborator

How urgent are these modifications - is there a need to integrate the new library version into openDAQ and update the versions of fmt and spdlog similarly there? I ask because the latest version of the project is incompatible with openDAQ main - the two latest commits break compatibility, and the corresponding branch in openDAQ is still in progress and not yet merged - it will probably be merged in the next two days.
However, if necessary, I could revert the latest changes in the main branch here for now to unblock the further integration.

@Unsttopabull
Copy link
Contributor Author

Not that necessary, I can create v1.0.4-2 with just include/native_streaming/logging.hpp fix only

@Unsttopabull Unsttopabull force-pushed the other/fix-new-fmt-compatibility branch from f491b52 to c6fce85 Compare March 7, 2024 13:58
@Unsttopabull Unsttopabull merged commit e66ef6c into main Mar 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants