AA auto full screen #87

egisz · 2021-08-03T17:42:22Z

Description:

Added setting for automatic switch to full screen mode when AA is connected.
If setting is ON, AA switch to full screen when connected.
Dash switch to non full screen when device disconnects.

fixes #27

Checklist:

The code change is tested and works locally.

and back on disconnect

rsjudka · 2021-08-04T02:01:43Z

lgtm! ill let some ppl test it out to see how they feel about the flow

egisz · 2021-08-04T06:55:44Z

I was hesitatining how to name setting, it's named: Force AA fullscreen
I'ts short, but maybe it's not that clear what does it do?
Alternatives could be:

Auto switch AA to fullscreen
Auto fullscreen on AA connect
Force fullscreen AA when it connects
your proposed :)

stefan-sherwood · 2021-08-04T10:43:05Z

Fullscreen Android Auto

robert5974 · 2021-08-04T11:00:03Z

Maybe: AA Fullscreen: Automatic AA Fullscreen: Auto (might sound redundant) Maybe add another option for a delay before switch: AA Fullscreen: Delay

Choose number

Radial button for seconds or minutes Robert Crowley

…

On Wed, Aug 4, 2021, 6:43 AM stefan-sherwood ***@***.***> wrote: Fullscreen Android Auto — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLUDVGQNJXVIXXPHGRG4M3T3EKUJANCNFSM5BPJRO3Q> .

egisz · 2021-08-05T05:41:57Z

Initially I thought of delay, but is it really needed? It also can be inconvinient if you start AA, want to click on some UI element and suddenly it become fullscreen.

Regarding setting name, I think we can omit AA/Android auto because settings are inside AA page, so they are all related to AA :)

Switch fullscreen on connect
Fullscreen mode <------- this is my current favorite, simple and clear :)

stefan-sherwood · 2021-08-05T12:45:04Z

Simple and clear is good. I didn't realize the settings were in the AA section and I agree. How about just "Fullscreen"?

TheBasedDoge · 2021-08-05T21:53:54Z

Its working great for me but I noticed 2 things.

For some reason in dark mode, not all the icons are changing to white. I noticed this in your picture as well so not sure if related.
There is a green line on the right side of the screen in fullscreen, I don't think that was there before
When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

"fullscreen mode" sounds the best to me, simple and clear.

egisz · 2021-08-06T07:19:36Z

Its working great for me but I noticed 2 things.

For some reason in dark mode, not all the icons are changing to white. I noticed this in your picture as well so not sure if related.

Tested on develop branch, and it is same, so this is not relevant to this update, please report it as separate isssue
See screenshot below, power and exit buttons are too dark for dark theme...

There is a green line on the right side of the screen in fullscreen, I don't think that was there before

I noticed this also, but checked on develop branch it also exist, so it is not relevant to this update. Please report it as separate Issue.

When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

Good point! I'll try fix this.

robert5974 · 2021-08-06T10:52:37Z

I've been noticing the green line myself too. It's not noticeable when not Fullscreen but I could see it. I use the official Raspberry Pi 7" screen. Does anybody that has a different screen see this?

As in, is it seen in a different resolution than 800x480?

TheBasedDoge · 2021-08-06T12:13:59Z

I've been noticing the green line myself too. It's not noticeable when not Fullscreen but I could see it. I use the official Raspberry Pi 7" screen. Does anybody that has a different screen see this?

As in, is it seen in a different resolution than 800x480?

yes, i am using 1024x600

egisz · 2021-08-06T17:30:29Z

When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

Pushed new commit to branch, it now toggles fullscreen when cycling between pages
Also renamed setting label to Fullscreen mode.

TheBasedDoge · 2021-08-06T17:51:24Z

cool! i will try it

…lscreen

rsjudka · 2021-08-16T03:35:50Z

not ignoring this, but looks like the changes are touching more than just the AA page now so i want to look at it a bit closer

egisz · 2021-08-16T10:02:58Z

Yes, I did not mention, but latest update introduces fullscreen mode globally, not only in AA window.
Reason why I did this is because I also wanted backup camera fullscreen. Maybe it would be also better option for some widgets or media player.

It captures double click in all screens and toggles between fullscreen/non fullscreen mode.
Added animation to hide menus (user can disable this in settings).
Settings moved to Settings page/Layout page.
Also added notification dialog once user switches to fullscreen to inform how to switch back. It can be disabled by checking box "Do not show again".

I tested on PC, it works well, but on Rpi, this dialog sometimes does not come up. It should appear each time I toggle screen, until I check box "Do not show again", but it only shows up once after going to full screen, but after I hit cancel, it does not. I believe it opens, but not visible. I'll try to fix this, tried multiple ways, so help would be welcome. :)

show Fullscreen notification only once during app run.

egisz · 2021-08-17T20:49:52Z

Finally it seems working as expected, could someone else test it?

I had problems with RPI Lite environment, but finally found solution.
Actually other Dash dialogs (like Power off) also does not return Keyboard focus after closing them, but it's another story. On X11 (Raspian Desktop or Ubuntu) everything works fine, so it was bit challenging to find cause :(

Another anoying thing was that dialog was not centered because it was opened before main window is shown. Here there is anoter workaround to open dialog it inside singleshot timer.

rsjudka · 2021-09-09T03:30:07Z

yes ill try catching up with the PRs after I finish the vehicle widget stuff!

keyboard focus is definitely an entirely different issue for another time :p

as for the "not centered" workaround... since the dialog is a lot of custom code its entirely possible I did something wrong there. As long as the workaround isn't anything major I think its okay to keep it for now and then fix it later on

rsjudka · 2021-12-15T02:05:15Z

oops sorry looks like there are some conflicts with my recent commit (probs related to coloring the icons and whatnot)

mind fixing them so I can test out your changes?

…lscreen

egisz · 2021-12-15T19:22:18Z

sure, try now :)

rsjudka · 2021-12-16T04:23:21Z

i think some other changes might have snuck in here? (looking at the canbus stuff mainly)

rsjudka · 2021-12-16T04:54:51Z

so i tried running it (not on a pi so that might be a factor) but...

egisz · 2022-01-10T23:12:56Z

Please try now, fixed duplicate icons, that was caused by bug left during merge confict file...
also fixed few annoying build warnings.
It looks and works fine now

src/app/window.cpp

src/app/pages/settings.cpp

rsjudka · 2022-01-12T06:03:55Z

src/app/window.cpp

+    int fullscreen_delay = this->arbiter.layout().fullscreen_delay;
+    if (fullscreen && fullscreen_delay != 0) {
+        this->arbiter.toggle_fullscreen_mode();
+        this->arbiter.toggle_fullscreen_mode();


duplicate line here?

yes, this is on purpose to trigger animation.

i removed the duplicated line and it seemed to work just fine (tried with all animation levels)

src/app/pages/settings.cpp

rsjudka · 2022-01-15T01:09:01Z

if you exit dash when in fullscreen mode, it doesn't seem to launch in fullscreen mode on the next boot (even though it shows as toggled in the settings)

rsjudka · 2022-01-26T00:26:02Z

if you exit dash when in fullscreen mode, it doesn't seem to launch in fullscreen mode on the next boot (even though it shows as toggled in the settings)

interesting... this is only an issue when the animation duration is 0

rsjudka · 2023-03-14T02:40:04Z

havent seen any movement on this and then i ended up changing how fullscreen works in #138 so its not compatible now

good news is auto fullscreen should be much simpler to do now 👍

egisz added 3 commits August 2, 2021 12:22

force aa fullscreen on connection

ab6b209

add config value to setting page

f096086

switch to fullscreen on AA connect

3e58536

and back on disconnect

restore to fullscreen when cycling between pages

cfdadb4

egisz added 2 commits August 10, 2021 16:52

fixes openDsh#89 Welcome / AA screen dissapear after clicking on AA icon

bb3436f

Merge branch 'develop' of https://github.com/openDsh/dash into aa_ful…

13bf804

…lscreen

egisz mentioned this pull request Aug 10, 2021

Welcome / AA screen dissapear after clicking on AA icon. #89

Open

egisz added 3 commits August 11, 2021 15:42

WIP apply fullscreen in all Dash windows

2de7907

fullscreen mode rework

1f1f806

remove fullscreen stuff from openauto page

306b098

egisz added 2 commits August 17, 2021 18:02

fix loosing keyboard focus on eglfs (RPI Lite)

c3ae193

show Fullscreen notification only once during app run.

cleanup old settings

32f5ab2

fix wrong type

e1a48fd

egisz mentioned this pull request Aug 19, 2021

In dark mode, not all the icons are changing to white #95

Closed

stefan-sherwood mentioned this pull request Aug 31, 2021

Green vertical border right hand side #101

Closed

egisz added 4 commits December 15, 2021 19:41

changes

6c8697d

Merge branch 'develop' of https://github.com/openDsh/dash into aa_ful…

3df4641

…lscreen

fixes after merge

cf66863

one more fix

1047a39

egisz added 3 commits January 10, 2022 22:27

revert canbus mods

f47b86a

fix duplicate menu icons

106e5c3

fix annoying warnings during build

99536dd

rsjudka reviewed Jan 11, 2022

View reviewed changes

src/app/window.cpp Outdated Show resolved Hide resolved

rsjudka reviewed Jan 11, 2022

View reviewed changes

src/app/window.cpp Outdated Show resolved Hide resolved

rsjudka reviewed Jan 11, 2022

View reviewed changes

src/app/pages/settings.cpp Show resolved Hide resolved

egisz added 2 commits January 11, 2022 08:39

fixes according feedback on PR

a72f47b

fix gstreamerRepo URL

ed4e4f5

rsjudka reviewed Jan 12, 2022

View reviewed changes

src/app/pages/settings.cpp Outdated Show resolved Hide resolved

settings page fixes, fullscreen mode

b512823

rsjudka closed this Mar 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AA auto full screen #87

AA auto full screen #87

egisz commented Aug 3, 2021

rsjudka commented Aug 4, 2021

egisz commented Aug 4, 2021 •

edited

Loading

stefan-sherwood commented Aug 4, 2021

robert5974 commented Aug 4, 2021 via email

egisz commented Aug 5, 2021

stefan-sherwood commented Aug 5, 2021

TheBasedDoge commented Aug 5, 2021

egisz commented Aug 6, 2021

robert5974 commented Aug 6, 2021

TheBasedDoge commented Aug 6, 2021

egisz commented Aug 6, 2021 •

edited

Loading

TheBasedDoge commented Aug 6, 2021

rsjudka commented Aug 16, 2021

egisz commented Aug 16, 2021 •

edited

Loading

egisz commented Aug 17, 2021

rsjudka commented Sep 9, 2021

rsjudka commented Dec 15, 2021

egisz commented Dec 15, 2021

rsjudka commented Dec 16, 2021

rsjudka commented Dec 16, 2021

egisz commented Jan 10, 2022

rsjudka Jan 12, 2022

egisz Jan 12, 2022 •

edited

Loading

rsjudka Jan 15, 2022

rsjudka commented Jan 15, 2022

rsjudka commented Jan 26, 2022

rsjudka commented Mar 14, 2023

AA auto full screen #87

AA auto full screen #87

Conversation

egisz commented Aug 3, 2021

Description:

Checklist:

rsjudka commented Aug 4, 2021

egisz commented Aug 4, 2021 • edited Loading

stefan-sherwood commented Aug 4, 2021

robert5974 commented Aug 4, 2021 via email

egisz commented Aug 5, 2021

stefan-sherwood commented Aug 5, 2021

TheBasedDoge commented Aug 5, 2021

egisz commented Aug 6, 2021

robert5974 commented Aug 6, 2021

TheBasedDoge commented Aug 6, 2021

egisz commented Aug 6, 2021 • edited Loading

TheBasedDoge commented Aug 6, 2021

rsjudka commented Aug 16, 2021

egisz commented Aug 16, 2021 • edited Loading

egisz commented Aug 17, 2021

rsjudka commented Sep 9, 2021

rsjudka commented Dec 15, 2021

egisz commented Dec 15, 2021

rsjudka commented Dec 16, 2021

rsjudka commented Dec 16, 2021

egisz commented Jan 10, 2022

rsjudka Jan 12, 2022

Choose a reason for hiding this comment

egisz Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

rsjudka Jan 15, 2022

Choose a reason for hiding this comment

rsjudka commented Jan 15, 2022

rsjudka commented Jan 26, 2022

rsjudka commented Mar 14, 2023

egisz commented Aug 4, 2021 •

edited

Loading

egisz commented Aug 6, 2021 •

edited

Loading

egisz commented Aug 16, 2021 •

edited

Loading

egisz Jan 12, 2022 •

edited

Loading