Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates and changes in the library #16

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Major updates and changes in the library #16

merged 1 commit into from
Jul 3, 2021

Conversation

danishjamal104
Copy link
Collaborator

Below are the changes this PR includes

  1. Removed all the models.
  2. Removed/fixed the model related areas.
  3. Modified BaseApiManager and its implementation.
    1. Removed the userPreference property from implementation class, since it was only used for getting instance url and tenant viz now passed in create service method itself.
    2. Modified function signature, now each function returns NonNullable object.
    3. ConvertorFactory and CallAdapterFactory modified.
  4. Mappers design modified
    1. Two more methods, mapFromEntityList and mapToEntityList added in EntityMapper interface.
    2. Created new class AbstractMapper, which implements the above two methods and open rest to be implemented accordingly.
    3. Now onwards for getting the generic behaviour all the mappers must extend the AbstractMapper and for custom logic implement EntityMapper.

@danishjamal104 danishjamal104 added enhancement New feature or request priority Address this on priority labels Jul 2, 2021
@danishjamal104 danishjamal104 self-assigned this Jul 2, 2021
@danishjamal104 danishjamal104 merged commit fbf13d9 into openMF:development Jul 3, 2021
@danishjamal104 danishjamal104 deleted the major branch July 3, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GSoC 2021 priority Address this on priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant