Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add a confirmation dialog in forgot passcode #86

Closed
rchtgpt opened this issue Dec 5, 2019 · 9 comments · Fixed by #95
Closed

Bug: Add a confirmation dialog in forgot passcode #86

rchtgpt opened this issue Dec 5, 2019 · 9 comments · Fixed by #95

Comments

@rchtgpt
Copy link
Member

rchtgpt commented Dec 5, 2019

Summary:
When user clicks on "Forgot passcode, login manually", he is directed to login page directly. However a cofirmation dialog should confirm whether he/she really wants to login manually. This will enhance the User Experience.

Steps to reproduce:

  1. Go to Passcode Activity
  2. Click on "Forgot passcode, login manually" button
  3. You will be directed to the Login Activity

Expected behaviour:
Before directing to the login activity, a dialog should pop up to confirm the action.
Observed behaviour:
.No Confirmation takes place

Device and Android version:

Device - Mi A2
Android 9 Pie

GIF:
ezgif com-video-to-gif (6)

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 5, 2019

Can I start working on this issue ? @abhijitramesh @harshshinde07

@harshshinde07
Copy link

@Rachittt Unless and until any critical action is taking place, I don't really think there is a need for any kind of confirmation dialog. This situation does not cause any harm as such.

Take an example of log out button, when user logs out, he/she has to manually re-enter the login credentials. This task is critical as the user might have clicked the log out by mistake or even have forgotten the credentials. Only in such critical tasks we need a confirmation dialog.

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 5, 2019

@harshshinde07 if a person clicks on the forgot passcode button by mistake, he has to manually enter the password as well as set up a new passcode and then confirm that passcode. I just thought maybe adding a confirmation dialog as we did in 'Mifos Mobile' would enhance the user experience of the User.

@harshshinde07
Copy link

Does it go back to the passcode activity on pressing back button?

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 5, 2019

@harshshinde07 as of now, nope

@harshshinde07
Copy link

I personally don't think adding the dialog here is a good practice. So just redirecting it back to passcode should work for now. What are your thoughts @luckyman20 ?

@luckyman20
Copy link
Collaborator

@harshshinde07 well, we can add a confirmation dialog.

@Rachittt Go ahead :)

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 5, 2019

Cool! @luckyman20 Can you assign this task to me while I work on it ?

@luckyman20
Copy link
Collaborator

@Rachittt Well, it is not necessary that you contribute through tasks only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants