fix#2589: Migrate QrCodeReaderFragment from XML to compose #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose
fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose
fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose
fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose
AvneetSingh2001
requested changes
May 17, 2024
| .fillMaxSize() | ||
| .padding(it), | ||
| ) { | ||
| AndroidView({ scannerView }) |
There was a problem hiding this comment.
dont we have any other options than AndroidView?
There was a problem hiding this comment.
"Unfortunately, as of now, there's no direct replacement in Jetpack Compose for ZXingScannerView that doesn't use AndroidView."
I looked up online and it was the only way I found. Probably we don't have another way of doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2589
Screencast_05_17_2024_03.42.28_PM.webm