Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: only supports scale_factor 1, which gives blurry images #1032

Closed
MBilderbeek opened this issue Aug 4, 2016 · 6 comments
Closed

Comments

@MBilderbeek
Copy link
Member

The Android port has hardcoded scale_factor 1, which means TEXT80 and screen 6 and 7 images become blurry.

Perhaps it should be possible to change scale_factor, possibly after which the app needs to be restarted?

@MBilderbeek
Copy link
Member Author

With the current Android SDL port, the app crashes when changing screen mode while the app is running. I don't expect this to get fixed soon.
I also don't know how to switch mode after restarting the app. (That may require some hacky code with persistence files etc.)

What we can do is instead of hardcoding the scale_factor to 1, to hardcode it to factor 2. With this TEXT80 looks good at least, and you also get scanlines and stuff.

On my reasonably new phone (Xiaomi Redmi 4 Prime) this works fine and it is still running at 60fps even at the toughest conditions (turboR/V9990/Moonsound). But perhaps this will break the app for people with some (older) Android devices, either the display may go weird or it becomes too slow.

What do you think?

@awulms
Copy link

awulms commented Aug 23, 2018 via email

@MBilderbeek
Copy link
Member Author

Thanks! Can you also check whether you can build the latest Android code? It will be necessary if you want to upload a signed binary to Google Play for next release.

One of these days I'll then switch it to 2x... until we get some evidence we shouldn't :)

@awulms
Copy link

awulms commented Aug 24, 2018 via email

@MBilderbeek
Copy link
Member Author

The sooner you try, the better. It has become much harder and much less trivial to setup. I'll do my utmost to help you with that. I already tried to update the Compilation Guide, but I know there are still parts missing.

MBilderbeek added a commit that referenced this issue Aug 28, 2018
As discussed in #1032... Let's give it a try.
@MBilderbeek
Copy link
Member Author

I'm considering this ticket done for now. @awulms please contact me about setting up the development environment. I think we'd like to release soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants