Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoints set at the new GUI not cleared correctly by commands #1627

Closed
Colpocorto opened this issue May 20, 2024 · 2 comments
Closed

Breakpoints set at the new GUI not cleared correctly by commands #1627

Colpocorto opened this issue May 20, 2024 · 2 comments
Labels
Debugger imgui Issues related to the Dear ImGui functionality

Comments

@Colpocorto
Copy link

Steps to reproduce it:

-Start OpenMSX
-Open Debugger > Breakpoints
-Add a breakpoint at #38 (or any other address that is frequently hit) for any slot (X/X)
-Close Breakpoints window
-Close OpenMSX
-Start OpenMSX again. The execution will stop at #38 (the breakpoint is still there).
-Open Console, type debug list_bp and debug remove_bp bp#1 (or the one returned by list_bp).
-Continue the execution
-Close OpenMSX
-Start OpenMSX. The breakpoint has respawned.

It only happens if the Breakpoint is closed when the debug remove_bp command is executed. If the Breakpoint window is open, the breakpoint is correctly cleared with debug remove_bp.

Version: OpenMSX 19.1-909
OS: Windows 10 64bit (Intel)
@MBilderbeek MBilderbeek added imgui Issues related to the Dear ImGui functionality Debugger labels May 20, 2024
@m9710797
Copy link
Contributor

Thanks for reporting!
The hint about "... it only happens when the Breakpoint window is closed ..." was very useful, I think I know what the problem might be. I'll try to verify and fix it this evening.

m9710797 added a commit that referenced this issue May 21, 2024
@m9710797
Fix issue#1627 Breakpoints set at the new GUI not cleared correctly b…
ba505b2 
…y commands

For a more detailed description see:
    #1627

The problem was that when the Breakpoints window is not open (nor the
disassembly view) we didn't sync the GUI-breakpoints with the internal
openMSX breakpoints. And then they could still wrongly be saved in
imgui.ini
@m9710797
Copy link
Contributor

Fixed. It works for me now. But please also verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debugger imgui Issues related to the Dear ImGui functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m9710797 @MBilderbeek @Colpocorto