Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad MSVC preprocessor definition /bigobj #1146

Closed
rwiesenfarth opened this issue Nov 13, 2017 · 2 comments
Closed

Bad MSVC preprocessor definition /bigobj #1146

rwiesenfarth opened this issue Nov 13, 2017 · 2 comments
Assignees
Milestone

Comments

@rwiesenfarth
Copy link
Contributor

Compiling OpenMVG on Windows with MSVC creates a compiler command line including '/D "/bigobj"' instead of the intended '/bigobj'

Although the build succeeds, IntelliSense marks the first char in every .cpp file with an error (see attachment).

I have a working fix for this and will provide a pull request.

openmvg_bigobj_error

@pmoulon
Copy link
Member

pmoulon commented Dec 18, 2017

I took a deeper look and in fact the /bigobj is needed only in Debug mode for the target openMVG_sfm and openMVG_matching:

I'm testing it right now there:
b81a36c#diff-51a7011e2497130a3d10c187652e3772R46
b81a36c#diff-c4e7d384906636d63dabada049b55348R42

@pmoulon pmoulon added this to the 1.X milestone Dec 18, 2017
@pmoulon pmoulon self-assigned this Dec 18, 2017
@pmoulon
Copy link
Member

pmoulon commented Jan 15, 2018

Can be closed since this issue is now fixed by c054265

@pmoulon pmoulon closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants