Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0: Fails to use external cereal #1963

Closed
yurivict opened this issue Nov 14, 2021 · 1 comment
Closed

2.0: Fails to use external cereal #1963

yurivict opened this issue Nov 14, 2021 · 1 comment
Labels
build enhancement help_wanted
Milestone
2.1

Comments

@yurivict
Copy link

yurivict commented Nov 14, 2021 •
edited

The code checks for cereal target. Such target isn't found but cereal_FOUND is set. cereal_FOUND is the variable that it should check.

The code also unconditionally checks that the cereal submodule is present even when external cereal can be used.
@yurivict yurivict changed the title 2.0: Fails to use external celeral 2.0: Fails to use external cereral Nov 14, 2021
@yurivict yurivict changed the title 2.0: Fails to use external cereral 2.0: Fails to use external cereal Nov 14, 2021
@pmoulon
Copy link
Member

pmoulon commented Dec 4, 2021 •
edited

Thank you for reporting, we can definitely do better.
Can you try the potential fix I tried below?

Regarding the unconditionally check, I don't see this as an issue since we check only that submodule has been checkout.

pmoulon added a commit that referenced this issue Dec 4, 2021
@pmoulon
[Build] Fix potential use of external cereal #1963
55f3eec
@pmoulon pmoulon added this to the 2.1 milestone Dec 18, 2021
@pmoulon pmoulon closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build enhancement help_wanted
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@yurivict @pmoulon