Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #1855

Closed
wants to merge 15 commits into from
Closed

Master #1855

wants to merge 15 commits into from

Conversation

kevinsmia1939
Copy link

Use GNUInstallDirs for directories. Fix for this #1852.
I tried using openMVG pipeline to check if it work, it does work, but check to make sure.

Kind regards

@pmoulon
Copy link
Member

pmoulon commented Feb 7, 2021

Thank you. I will take a look during the week and let you know. FYI when you run install there is a manifest file that trace all the file that have been install. By looking to it you can check if there is any file going in the wrong path.

@kevinsmia1939
Copy link
Author

kevinsmia1939 commented Feb 8, 2021

Thank you. I will take a look during the week and let you know. FYI when you run install there is a manifest file that trace all the file that have been install. By looking to it you can check if there is any file going in the wrong path.

Hello,

I build openMVG to check all the files, it went to the correct path. I ran openMVGopenMVS pipeline python file, and it generate mesh just fine.
I only apply gnuinstalldir to lib only, I left bin and include alone because I don't know if I will break them, but if you want me to cover them too let me know.

@pmoulon
Copy link
Member

pmoulon commented Feb 9, 2021

Let's do step by step. Starting with the LIB is a good start

@pmoulon pmoulon added this to the 2.0 milestone Mar 24, 2021
@pmoulon pmoulon self-assigned this Mar 24, 2021
@pmoulon pmoulon modified the milestones: 2.0, 2.1 Oct 20, 2021
@@ -1,3 +1,4 @@
include(GNUInstallDirs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this include only once (only in the primary cmake the one in src/CMakeLists.txt)

@pmoulon
Copy link
Member

pmoulon commented Feb 2, 2023

Solved by integrating #2148

@pmoulon pmoulon closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants