Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Modernize cmake openmp usage #1978

Merged
merged 1 commit into from Dec 4, 2021
Merged

[Build] Modernize cmake openmp usage #1978

merged 1 commit into from Dec 4, 2021

Conversation

pmoulon
Copy link
Member

@pmoulon pmoulon commented Dec 4, 2021

No description provided.

@pmoulon pmoulon merged commit 7337716 into develop Dec 4, 2021
@pmoulon pmoulon deleted the develop_modernize_openmp_usage branch December 4, 2021 06:00
@rjanvier
Copy link
Member

rjanvier commented Dec 7, 2021

I think it lacks something like add_compile_definitions(-DOPENMVG_USE_OPENMP) when OpenMP is found else the pre processor won't be able to expose source code (where OPENMVG_USE_OPENMP is defined) to the compiler. What do you think?

@pmoulon
Copy link
Member Author

pmoulon commented Dec 7, 2021

You are right. I will fix this!

pmoulon added a commit that referenced this pull request Dec 8, 2021
@pmoulon
[Build] Modernize cmake openmp usage (Fix preprocessor and library na…
999d729 
…me) #1978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmoulon @rjanvier