Ensure we don't lose precision when exporting to txt #2010
Conversation
|
Thank you for this contribution. |
|
Sure, a global variable is OK or do you mean as an argument? |
|
I would prefer as argument |
…ating-point values
|
@pmoulon updated by adding an argument option. |
|
LGTM, I think your code editor is using tabs, and not 2spaces as 'tab' |
| @@ -36,9 +36,13 @@ using namespace openMVG::features; | |||
|
|
|||
| bool CreateLineCameraFile( const IndexT camera_id, | |||
| std::shared_ptr<openMVG::cameras::IntrinsicBase> intrinsic, | |||
| std::string & camera_linie) | |||
| std::string & camera_linie, | |||
There was a problem hiding this comment.
Would you mind add a commit to fix this typo camera_linie -> camera_line
Thanks ;-)
There was a problem hiding this comment.
Fixed, spent half of the day adjusting indentation :)
|
|
||
| << "[-o|--outdir] path where cameras.txt, images.txt and points3D.txt will be saved" | ||
| << "\n[Optional]\n" | ||
| << "[-p|--precision] sets the decimal precision to be used to format floating-point values (default = 16)"; |
There was a problem hiding this comment.
Ideally you would display the value of the variable here floating_point_precision_digit
|
Running Continous Integration build and unit test. But it LGTM |
|
|
||
| << "[-o|--outdir] path where cameras.txt, images.txt and points3D.txt will be saved" | ||
| << "\n[Optional]\n" | ||
| << "[-p|--precision] sets the decimal precision to be used to format floating-point values (default = 16)"; |
Sure, anytime! You are the one to thank for this awesome amount of work! |
Set precision when exporting to COLMAP text files to avoid precision loss. (mostly when the scene is in global coordinates)