New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builds on Mac OS 12 AppleClang + OpenMP #2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiles and links in develop branch using Xcode 13.3 under macOS Monterey 12.2.1 (march/2022). Likely also builds with XCode 12.5.1 under Big Sur. The problem was that cmake would proceed OK, but there were build errors such as 'omp.h' not found. See Issue openMVG#1727. See also this commit in an unmerged PR for additional fixes that may be needed in other branches: openMVG@b775118
rfabbri
commented
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please add "Fixes #2008" to the commit message.
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found" Inspired by "builds on Mac OS 12 AppleClang + OpenMP", github.com/openMVG/openMVG/pull/2038
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found" Inspired by "builds on Mac OS 12 AppleClang + OpenMP", github openMVG/openMVG/pull/2038
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found" Also fixed MacOS/OpenMP linker errors, saying: > Undefined symbols for architecture x86_64: > "___kmpc_for_static_fini", referenced from: > _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o > "___kmpc_for_static_init_4", referenced from: > _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o > "___kmpc_fork_call", referenced from: > OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o > "_omp_set_num_threads", referenced from: > OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o Inspired by pull request openMVG/openMVG#2038 "builds on Mac OS 12 AppleClang + OpenMP"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found" Also fixed MacOS/OpenMP linker errors, saying: > Undefined symbols for architecture x86_64: > "___kmpc_for_static_fini", referenced from: > _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o > "___kmpc_for_static_init_4", referenced from: > _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o > "___kmpc_fork_call", referenced from: > OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o > "_omp_set_num_threads", referenced from: > OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o Inspired by pull request openMVG/openMVG#2038 "builds on Mac OS 12 AppleClang + OpenMP"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles and links in develop branch using Xcode 13.3 under
macOS Monterey 12.2.1 (march/2022).
Likely also builds with XCode 12.5.1 under Big Sur.
The problem was that cmake would proceed OK,
but there were build errors such as 'omp.h' not found (Fixes #2008,#1727)
Reference fix: FluidSynth/fluidsynth@486e0f5
See also this commit in an unmerged PR for
additional fixes that may be needed in other branches:
b775118