Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds on Mac OS 12 AppleClang + OpenMP #2038

Merged
merged 1 commit into from Apr 16, 2022

Conversation

rfabbri
Copy link
Contributor

@rfabbri rfabbri commented Mar 29, 2022

Compiles and links in develop branch using Xcode 13.3 under
macOS Monterey 12.2.1 (march/2022).
Likely also builds with XCode 12.5.1 under Big Sur.
The problem was that cmake would proceed OK,
but there were build errors such as 'omp.h' not found (Fixes #2008,#1727)

Reference fix: FluidSynth/fluidsynth@486e0f5

See also this commit in an unmerged PR for
additional fixes that may be needed in other branches:
b775118

Compiles and links in develop branch using Xcode 13.3 under
macOS Monterey 12.2.1 (march/2022).
Likely also builds with XCode 12.5.1 under Big Sur.
The problem was that cmake would proceed OK,
but there were build errors such as 'omp.h' not found.
See Issue openMVG#1727.

See also this commit in an unmerged PR for additional fixes that may be needed in other
branches:
openMVG@b775118
Copy link
Contributor Author

@rfabbri rfabbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, please add "Fixes #2008" to the commit message.

@pmoulon pmoulon added this to the 2.1 milestone Apr 16, 2022
@pmoulon pmoulon added the build label Apr 16, 2022
@pmoulon pmoulon self-assigned this Apr 16, 2022
@pmoulon pmoulon merged commit 34f188b into openMVG:develop Apr 16, 2022
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found"

Inspired by "builds on Mac OS 12 AppleClang + OpenMP", github.com/openMVG/openMVG/pull/2038
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found"

Inspired by "builds on Mac OS 12 AppleClang + OpenMP", github openMVG/openMVG/pull/2038
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found"

Also fixed MacOS/OpenMP linker errors, saying:

> Undefined symbols for architecture x86_64:
> "___kmpc_for_static_fini", referenced from:
>     _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o
>  "___kmpc_for_static_init_4", referenced from:
>     _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o
>  "___kmpc_fork_call", referenced from:
>      OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o
>  "_omp_set_num_threads", referenced from:
>      OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o

Inspired by pull request openMVG/openMVG#2038 "builds on Mac OS 12 AppleClang + OpenMP"
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Sep 9, 2022
Addresses issue #650 "MacOS GitHub Actions, Azure Pipelines fatal error: ‘omp.h’ file not found"

Also fixed MacOS/OpenMP linker errors, saying:

> Undefined symbols for architecture x86_64:
> "___kmpc_for_static_fini", referenced from:
>     _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o
>  "___kmpc_for_static_init_4", referenced from:
>     _.omp_outlined. in itkAdvanceOneStepParallellizationTest.cxx.o
>  "___kmpc_fork_call", referenced from:
>      OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o
>  "_omp_set_num_threads", referenced from:
>      OptimizerTEMP::AdvanceOneStep() in itkAdvanceOneStepParallellizationTest.cxx.o

Inspired by pull request openMVG/openMVG#2038 "builds on Mac OS 12 AppleClang + OpenMP"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue on Mac OS (omp.h not found)
2 participants