Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build againt cereal>1.3.0 #2071

Merged
merged 2 commits into from May 23, 2022
Merged

Fix build againt cereal>1.3.0 #2071

merged 2 commits into from May 23, 2022

Conversation

bartoszek
Copy link
Contributor

As of careal=1.3.1 target requires component

Fix build againt cereal>1.3.0
322feb4 
As of careal=1.3.1 target requires component
pmoulon
pmoulon reviewed May 19, 2022
View reviewed changes
Copy link
Member

@pmoulon pmoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. We just have to check behavior with component and if library is propagated or not as a dependency since behavior is different for components (remember that cmake can't track if dynamic or static so you need the 'find_dependency')

src/CMakeLists.txt Show resolved Hide resolved
@pmoulon pmoulon merged commit 1f9b938 into openMVG:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmoulon pmoulon pmoulon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartoszek @pmoulon