Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export masks to openMVS #2168

Merged
merged 1 commit into from Feb 21, 2023
Merged

Export masks to openMVS #2168

merged 1 commit into from Feb 21, 2023

Conversation

Sanheiii
Copy link
Contributor

No description provided.

@pmoulon
Copy link
Member

pmoulon commented Feb 20, 2023

LGTM, can you share an example where you used the features?

@Sanheiii
Copy link
Contributor Author

GitHub cannot upload files larger than 25MB, so please allow me to describe it.
In the picture you can see the input data and the final result.
I tried local masking, global masking and both. I got the results I expected.
image
image
image

@pmoulon
Copy link
Member

pmoulon commented Feb 21, 2023

Great. Thx you! Happy to receive your contribution @Sanheiii
Feel to make some others ;-)

@pmoulon pmoulon merged commit 3b19127 into openMVG:develop Feb 21, 2023
@pmoulon pmoulon added this to the 2.1 milestone Feb 21, 2023
@pmoulon pmoulon self-assigned this Feb 21, 2023
@pmoulon pmoulon self-requested a review February 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmoulon pmoulon Awaiting requested review from pmoulon

Assignees

@pmoulon pmoulon

Labels
enhancement
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sanheiii @pmoulon