New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
software: store relative paths for masks in MVS scene and fix global space IDs #2193
Conversation
ghost
commented
Apr 27, 2023
It's been awhile, so I'm just bumping this. @pmoulon (or some other maintainer) can we get this reviewed and merged? This fixes some issues I'm having with masks and OpenMVS. |
@Sanheiii I am planning on removing global IDs, are you using global IDs for anything? |
It's been a long time since my last commit, I don't remember the details of it, you can check the code to decide if you want to remove it or not. |
{
"name": "images\\DSC09972.JPG",
"mask_name": "images\\DSC09972.mask.png",
"platform_id": 0,
"camera_id": 0,
"pose_id": 27,
"id": 27
},
{
"name": "images\\DSC09973.JPG",
"mask_name": "images\\DSC09973.mask.png",
"platform_id": 1,
"camera_id": 0,
"pose_id": 0,
"id": 28
} @pmoulon good to go chef. |
|
||
Image() : platformID(NO_ID), cameraID(NO_ID), poseID(NO_ID), ID(NO_ID) {} | ||
Image() : platformID(NO_ID), cameraID(NO_ID), poseID(NO_ID), ID(NO_ID), minDepth(0), avgDepth(0), maxDepth(0) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4CJ7T I see more information here than what exists in https://github.com/cdcseacave/openMVS/blob/master/libs/MVS/Interface.h#L524 is it normal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the latest interface.h from the develop branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is compatible with the main branch of OpenMVS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4CJ7T Please let me know why this #2193 (comment) does not match OpenMVS repo |
Thank you |