fix: compilation for ubuntu22.04 arm64 #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmoulon
changed the title
pmoulon
reviewed
Oct 27, 2023
| #if defined __GNUC__ | ||
| __cpuid_count(x, 0, out[0], out[1], out[2], out[3]); | ||
| return true; | ||
| #if not defined __aarch64__ |
There was a problem hiding this comment.
This one should not be needed, since you already return false for aarch64, just before, right?
There was a problem hiding this comment.
yeah, but the compiler thinks this is an error:
There was a problem hiding this comment.
So we could have a unique if defined aarch64 return false here and remove the one on top, right?
There was a problem hiding this comment.
@jujimeizuo could you update the code to have only one entry with __aarch64__ so it would ease later maintenance?
jujimeizuo
force-pushed
the
compile-for-ubuntu22.04-arm64
branch
from
69bd616
to
f1e5818
Compare
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: On machines not built on x86-64 architecture, the
cpuid.hfile does not existfixed: #1881 (comment),
#if defined __aarch64__check architecture