Apply suggestions from code review

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
openPMD · Jan 11, 2022 · cc63e04 · cc63e04
1 parent 212b4ec
commit cc63e04
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/docs/source/details/backendconfig.rst b/docs/source/details/backendconfig.rst
@@ -1,7 +1,7 @@
 .. _backendconfig:
 
 JSON/TOML configuration
-==================
+=======================
 
 While the openPMD API intends to be a backend-*independent* implementation of the openPMD standard, it is sometimes useful to pass configuration parameters to the specific backend in use.
 :ref:`For each backend <backends-overview>`, configuration options can be passed via a JSON- or TOML-formatted string or via environment variables.

diff --git a/examples/13_write_dynamic_configuration.cpp b/examples/13_write_dynamic_configuration.cpp
@@ -8,16 +8,10 @@
 using std::cout;
 using namespace openPMD;
 
-bool hasAdios2()
-{
-    auto variants = getVariants();
-    auto iterator = variants.find( "adios2" );
-    return iterator != variants.end() && iterator->second;
-}
 
 int main()
 {
-    if( !hasAdios2() )
+    if( !getVariants()["adios2"] )
     {
         // Example configuration below selects the ADIOS2 backend
         return 0;

diff --git a/examples/13_write_dynamic_configuration.py b/examples/13_write_dynamic_configuration.py
@@ -4,10 +4,6 @@
 import numpy as np
 
 
-def hasAdios2():
-    return 'adios2' in io.variants and io.variants['adios2']
-
-
 # This example demonstrates how to use JSON/TOML-based dynamic
 # configuration for openPMD.
 # The following configuration is passed to the constructor of the Series
@@ -56,7 +52,7 @@ def hasAdios2():
 
 
 def main():
-    if not hasAdios2():
+    if not io.variants['adios2']:
         # Example configuration below selects the ADIOS2 backend
         return