Fix: MPI but no HDF5 #108
Merged
Fix: MPI but no HDF5 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the build if MPI is found but HDF5 is not. There are in principle several ways to react on that in the code, either by calling the alternative constructor, returning a dummy and writing an error, throwing or by re-designing the `#if` in the HDF5 parallel backend.
|
There was a fail-safe for HDF5+noMPI and noHDF5+MPI already: The construction of the handler would throw an error. |
|
Yes, I saw that :D But on top of that was a compile error when MPI was found but no HDF5 because the interfaces of the fallback itself differed :) |
|
So the fallback does not actually work for both combinations. Thanks for pointing this one out. This PR is a fix for the moment, but I will think about a solution that handles this more generally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build if MPI is found but HDF5 is not.
There are in principle several ways to react on that in the code, either by calling the alternative constructor, returning a dummy and writing an error, throwing or by re-designing the
#ifin the HDF5 parallel backend.@C0nsultant feel free to revise the strategy as it suits you :-)