Fix dirtyRecursive() performance for Series with many steps #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-performance-dirty-recursive
branch
from
b1b8875
to
bc7fca8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
reviewed
Mar 12, 2024
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
It's more performant now with the new implementation for dirtyRecursive
franzpoeschel
changed the title
franzpoeschel
commented
Mar 18, 2024
7 tasks
ax3l
approved these changes
Mar 25, 2024
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do an error-check if users accidentally touched an Iteration that is currently closed. It seems like we'll need to stop doing that as it leads to O(n^2) runtime where n is the number of IterationsThe check is still needed even in the regular logic, so the alternative was to make it more performant by tracking this information from the beginning.Fix: Clear dirty files after flushing in ADIOS2
cc @ax3l