Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++14 #825

Merged
merged 8 commits into from
Nov 24, 2020
Merged

C++14 #825

merged 8 commits into from
Nov 24, 2020

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 23, 2020

Require C++14 or newer.

@ax3l ax3l force-pushed the topic-cxx14 branch 3 times, most recently from fdc76b7 to af509d7 Compare November 24, 2020 08:10
Try to address:
```
In file included from /home/runner/work/openPMD-api/openPMD-api/include/openPMD/binding/python/Variant.hpp:26:0,
                 from /home/runner/work/openPMD-api/openPMD-api/include/openPMD/binding/python/Numpy.hpp:24,
                 from /home/runner/work/openPMD-api/openPMD-api/src/binding/python/Attributable.cpp:24:
/home/runner/work/openPMD-api/openPMD-api/share/openPMD/thirdParty/pybind11/include/pybind11/stl.h: In instantiation of ‘static pybind11::handle pybind11::detail::variant_caster<V<Ts ...> >::cast(Variant&&, pybind11::return_value_policy, pybind11::handle) [with Variant = mpark::variant ...
 /home/runner/work/openPMD-api/openPMD-api/src/binding/python/Attributable.cpp:337:10:   required from here
/home/runner/work/openPMD-api/openPMD-api/share/openPMD/thirdParty/pybind11/include/pybind11/stl.h:362:37: error: no matching function for call to ‘pybind11::detail::visit_helper<mpark::variant>::call(pybind11::detail::variant_caster_visitor, mpark::variant<
```
Too old for multi-return statements in constexpr functions:
  MSVC++ 14.0, _MSC_VER == 1900 (Visual Studio 2015 version 14.0)

New enough:
  MSVC++ 14.1, _MSC_VER == 1910 (Visual Studio 2017 version 15.0)
@ax3l ax3l force-pushed the topic-cxx14 branch 2 times, most recently from b5c1888 to 0999e0b Compare November 24, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants