Update gems #338

tsujigiri · 2016-12-26T21:47:14Z

Passwords now need to be 8 characters long (new default in authlogic).
To login to the Sidekiq web interface, log in to opensnp.org, if you
have the admin flag set, you will find it at the usual place.
I finally found out why Rubocop didn't complain about the frozen string literal pragma missing and added all of them.
Rubocop complained about keyword arguments, which is only relevant for Rails 5, so I disabled the cop.
I removed the inherit_from: .rubocop_todo.yml from .rubocop.yml, so Hound does complain about all the issues. I also added a few tasks for running Rubocop.

houndci-bot · 2016-12-26T21:47:22Z

db/migrate/20161226175703_add_admin_flag_to_users.rb

@@ -0,0 +1,5 @@
+class AddAdminFlagToUsers < ActiveRecord::Migration


Missing frozen string literal comment.

houndci-bot · 2016-12-26T21:47:22Z

test/functional/users_controller_test.rb

@@ -40,8 +40,8 @@ class UsersControllerTest < ActionController::TestCase
      should "be able to create accounts" do
        UsersController.any_instance.expects(:verify_recaptcha).returns(true)
        assert_difference 'User.count' do
-          put :create, user: { name: "Fubert Barfuß", password: 'jeheim',
-            password_confirmation: 'jeheim', email: 'fubert@example.com'}, read: 1
+          put :create, user: { name: "Fubert Barfuß", password: 'strengjeheim',


Use keyword arguments instead of positional arguments for http call: put.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-12-26T21:47:23Z

test/functional/users_controller_test.rb

@@ -30,8 +30,8 @@ class UsersControllerTest < ActionController::TestCase
      should "not be able to create accounts when failing reCAPTCHA" do
        UsersController.any_instance.expects(:verify_recaptcha).returns(false)
        assert_no_difference 'User.count' do
-          put :create, user: { name: "Fubert Barfuß", password: 'jeheim',
-            password_confirmation: 'jeheim', email: 'fubert@example.com'}, read: 1
+          put :create, user: { name: "Fubert Barfuß", password: 'strengjeheim',


Use keyword arguments instead of positional arguments for http call: put.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-12-26T21:47:23Z

spec/support/authlogic.rb

@@ -1,7 +1,7 @@
 module Authlogic
  module RequestSpecHelper
    def sign_in(user)
-      post user_session_path, user_session: { email: user.email, password: 'jeheim' }
+      post user_session_path, user_session: { email: user.email, password: 'strengjeheim' }


Use keyword arguments instead of positional arguments for http call: post.

houndci-bot · 2016-12-26T21:47:23Z

spec/spec_helper.rb

-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-end
+require 'simplecov'


Missing frozen string literal comment.

houndci-bot · 2016-12-26T21:47:23Z

lib/admin_constraint.rb

+class AdminConstraint
+  def matches?(request)
+    return false unless request.cookie_jar['user_credentials'].present?
+    user = User.find_by_persistence_token(request.cookie_jar['user_credentials'].split(':')[0])


Use find_by instead of dynamic find_by_persistence_token.

houndci-bot · 2016-12-26T21:47:23Z

lib/admin_constraint.rb

@@ -0,0 +1,7 @@
+class AdminConstraint


Missing frozen string literal comment.

* Passwords now need to be 8 characters long (new default in authlogic). * To login to the Sidekiq web interface, log in to opensnp.org, if you have the `admin` flag set, you will find it at the usual place.

houndci-bot · 2016-12-27T11:42:00Z

test/functional/users_controller_test.rb

        assert_difference 'User.count' do
-          put :create, user: { name: "Fubert Barfuß", password: 'jeheim',
-            password_confirmation: 'jeheim', email: 'fubert@example.com'}, read: 1
+          put :create, user: { name: "Fubert Barfuß", password: 'strengjeheim',


Use keyword arguments instead of positional arguments for http call: put.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-12-27T12:14:02Z

test/test_helper.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'


Missing frozen string literal comment.

houndci-bot · 2016-12-27T13:31:23Z

lib/tasks/rubocop.rake

@@ -0,0 +1,21 @@
+namespace :rubocop do


Missing frozen string literal comment.

On the CI two tests failed because the ReCaptcha site key wasn't set, even though ReCaptcha should be completely ignored in the tests.

tsujigiri · 2016-12-27T14:05:03Z

This should be good to go, now.

gedankenstuecke · 2017-01-03T09:59:23Z

Looks good to me. @philippbayer any complains from your side? 😺

gedankenstuecke

(trying this new review system for the first time) Looks good to me. Thanks for making the 🐶 happy!

tsujigiri · 2017-01-04T13:05:49Z

Sooo... should I merge or do we wait for @philippbayer to respond? 🙂

gedankenstuecke · 2017-01-04T13:09:02Z

Fire away, I think @philippbayer just arrived in 🇩🇪 this morning from 🇯🇵 , so it would be a few days before he's able to read straight again. 😂

houndci-bot reviewed Dec 26, 2016

View reviewed changes

lib/admin_constraint.rb

@@ -0,0 +1,7 @@

class AdminConstraint

Copy link

Collaborator

houndci-bot Dec 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

Update gems

5e24052

* Passwords now need to be 8 characters long (new default in authlogic). * To login to the Sidekiq web interface, log in to opensnp.org, if you have the `admin` flag set, you will find it at the usual place.

tsujigiri force-pushed the update-gems branch from ab107f3 to 5e24052 Compare December 27, 2016 11:41

houndci-bot reviewed Dec 27, 2016

View reviewed changes

Disable Rails/HttpPositionalArguments

ef75a7b

houndci-bot reviewed Dec 27, 2016

View reviewed changes

Add frozen string literal pragma to all files

0e23ed9

tsujigiri force-pushed the update-gems branch from f88be45 to 0e23ed9 Compare December 27, 2016 12:23

tsujigiri added 5 commits December 27, 2016 13:26

Remove unnecessary require

dfcfd84

Address another Rubocop complaint

0ce0e3b

Fix test failing on CI

1fa4390

Add tasks for running Rubocop

f7ece06

Address Rubocop complaints

b8f66fa

houndci-bot reviewed Dec 27, 2016

View reviewed changes

lib/tasks/rubocop.rake

@@ -0,0 +1,21 @@

namespace :rubocop do

Copy link

Collaborator

houndci-bot Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

tsujigiri added 3 commits December 27, 2016 14:33

Add missing frozen string literal pragma

c642656

This is not the fix you are looking for 👋

bfbc625

On the CI two tests failed because the ReCaptcha site key wasn't set, even though ReCaptcha should be completely ignored in the tests.

Update .env.example

82cf45d

gedankenstuecke self-requested a review January 3, 2017 10:13

gedankenstuecke approved these changes Jan 3, 2017

View reviewed changes

tsujigiri merged commit 906eef5 into openSNP:master Jan 4, 2017

tsujigiri deleted the update-gems branch January 4, 2017 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gems #338

Update gems #338

tsujigiri commented Dec 26, 2016 •

edited

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 26, 2016

houndci-bot Dec 27, 2016

houndci-bot Dec 27, 2016

houndci-bot Dec 27, 2016

tsujigiri commented Dec 27, 2016

gedankenstuecke commented Jan 3, 2017

gedankenstuecke left a comment

tsujigiri commented Jan 4, 2017

gedankenstuecke commented Jan 4, 2017

		@@ -0,0 +1,5 @@
		class AddAdminFlagToUsers < ActiveRecord::Migration

		@@ -1,4 +1,4 @@
		ENV["RAILS_ENV"] = "test"
		ENV['RAILS_ENV'] = 'test'

Update gems #338

Update gems #338

Conversation

tsujigiri commented Dec 26, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsujigiri commented Dec 27, 2016

gedankenstuecke commented Jan 3, 2017

gedankenstuecke left a comment

Choose a reason for hiding this comment

tsujigiri commented Jan 4, 2017

gedankenstuecke commented Jan 4, 2017

tsujigiri commented Dec 26, 2016 •

edited