Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set_config call from structure.sql #503

Merged
merged 1 commit into from Jun 14, 2018
Merged

Conversation

tsujigiri
Copy link
Collaborator

It's blocking and doesn't really do anything, it seems.

It's blocking and doesn't really do anything, it seems.
@philippbayer
Copy link
Member

Docs say:

If untrusted users have access to a database that has not adopted a secure schema usage pattern, begin each session by removing publicly-writable schemas from search_path. For example, add options=-csearch_path= to options, or issue EXEC SQL SELECT pg_catalog.set_config('search_path', '', false); after connecting. This consideration is not specific to ECPG; it applies to every interface for executing arbitrary SQL commands.

So I think too that can go, as we don't have untrusted users

@philippbayer philippbayer merged commit be67e24 into master Jun 14, 2018
@tsujigiri
Copy link
Collaborator Author

It's only for testing, anyway.

@tsujigiri tsujigiri deleted the fix-structure.sql branch June 14, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants