Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace factory_girl by factory_bot everywhere #510

Merged
merged 3 commits into from Oct 7, 2018
Merged

Replace factory_girl by factory_bot everywhere #510

merged 3 commits into from Oct 7, 2018

Conversation

philippbayer
Copy link
Member

So we get rid of a few warnings here and there

houndci-bot
houndci-bot reviewed Oct 7, 2018
View reviewed changes
spec/factories/user_phenotypes.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/user_snps.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/snps.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/picture_phenotypes.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/fitbit_sleeps.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/users.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/user_picture_phenotypes.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/user_achievements.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/snpedia_papers.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/snp_comments.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

houndci-bot
houndci-bot reviewed Oct 7, 2018
View reviewed changes
spec/factories/fitbit_profiles.rb
@@ -1,11 +1,11 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/achievements.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/genome_gov_papers.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

test/unit/mendeley_search_test.rb Outdated
existing_mendeley_paper = FactoryGirl.
build_stubbed(:mendeley_paper, uuid: uuid, snps: [@snp])
existing_mendeley_paper = FactoryBot
.build_stubbed(:mendeley_paper, uuid: uuid, snps: [@snp])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/MultilineMethodCallIndentation: Align .build_stubbed with FactoryBot on line 101.

Gemfile
@@ -79,7 +79,7 @@ end
group :development, :test do
gem 'uuidtools'
gem 'pry-rails', require: 'pry' unless ENV['CI']
gem 'factory_girl_rails'
gem 'factory_bot_rails'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem factory_bot_rails should appear before pry-rails.

spec/factories/plos_papers.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/phenotypes.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/phenotype_comments.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

spec/factories/fitbit_bodies.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true
FactoryGirl.define do
FactoryBot.define do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

@philippbayer philippbayer merged commit 1e1bdde into master Oct 7, 2018
@philippbayer philippbayer deleted the upgrade_factorygirl branch October 7, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippbayer @houndci-bot