Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken autocompletion overrides and restore default bash behavior #132

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

jengelh
Copy link
Contributor

@jengelh jengelh commented Jul 27, 2023

$ echo 'main(){}' >x.cpp
$ g++ x.cpp -o y.out
x.cpp:1:1: warning: ISO C++ forbids declaration of ‘main’ with no type [-Wreturn-type]
    1 | main(){}
      | ^~~~
$ gdb y<TAB><TAB>
yacc          yast2         ycpc          youtube-dl    yt-dlp
yast          yat2m         yes           ypdomainname  yzpper

The entire completion fluff is broken (inkscape too), so remove this altogether.

$ echo 'main(){}' >x.cpp
$ g++ x.cpp -o y.out
x.cpp:1:1: warning: ISO C++ forbids declaration of ‘main’ with no type [-Wreturn-type]
    1 | main(){}
      | ^~~~
$ gdb y<TAB><TAB>
yacc          yast2         ycpc          youtube-dl    yt-dlp
yast          yat2m         yes           ypdomainname  yzpper
@lnussel lnussel merged commit 32fa21e into openSUSE:master Aug 15, 2023
3 checks passed
@jengelh
Copy link
Contributor Author

jengelh commented Aug 15, 2023

For the record:

Before:

aaa_base-extras's profile.bash removed, bash-completion removed: TAB ok (standard)
aaa_base-extras's profile.bash removed, bash-completion installed: TAB ok (fancy)
aaa_base-extras's profile.bash installed, bash-completion installed: TAB ok (fancy)
aaa_base-extras's profile.bash installed, bash-completion removed: TAB broken (missing results / functions not found)

After:

[profile.bash is permanently removed; so, first two rows from above always apply]

Conclusion:

profile.bash contains garbage, and if bash-completion was installed, would paper over it and hide the issues (since loaded afterwards or something).

@bitstreamout
Copy link
Member

Yep not unterstood what complete.bash does therefore it has to be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants