Updates from code review

rust/agama-lib/src/network/types.rs

@@ -58,6 +58,8 @@ pub enum DeviceType {
     Bridge = 6,
 }
 
+// For now this mirrors NetworkManager, because it was less mental work than coming up with
+// what exactly Agama needs. Expected to be adapted.
 #[derive(Debug, Default, Clone, Copy, PartialEq, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub enum DeviceState {

rust/agama-server/src/network/model.rs

@@ -180,10 +180,11 @@ impl NetworkState {
     }
 
     pub fn remove_device(&mut self, name: &str) -> Result<(), NetworkStateError> {
-        // TODO: return an error if the device does not exist
-        if let Some(position) = self.devices.iter().position(|d| &d.name == name) {
-            self.devices.remove(position);
-        }
+        let Some(position) = self.devices.iter().position(|d| &d.name == name) else {
+            return Err(NetworkStateError::UnknownDevice(name.to_string()));
+        };
+
+        self.devices.remove(position);
         Ok(())
     }
 

rust/agama-server/src/network/nm/client.rs

@@ -152,7 +152,7 @@ impl<'a> NetworkManagerClient<'a> {
             {
                 devs.push(device);
             } else {
-                tracing::warn!("Ignoring network device: ");
+                tracing::warn!("Ignoring network device on path {}", &path);
             }
         }