Skip to content

Commit

Permalink
Include the encryption status in the device description (#1155)
Browse files Browse the repository at this point in the history
## Problem

- The device summary does not include the encryption status in the
device labels

## Solution

- Pass a new flag to `yast2-libstorage-ng` so the encryption status is
included in the labels
- See yast/yast-storage-ng#1379


## Testing

- Tested manually
  • Loading branch information
lslezak committed Apr 18, 2024
1 parent 4d6b858 commit 85c0ed5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion service/lib/agama/dbus/storage/interfaces/device/device.rb
Expand Up @@ -62,7 +62,7 @@ def device_name
#
# @return [String] e.g., "EXT4 Partition".
def device_description
Y2Storage::DeviceDescription.new(storage_device).to_s
Y2Storage::DeviceDescription.new(storage_device, include_encryption: true).to_s
end

def self.included(base)
Expand Down
2 changes: 1 addition & 1 deletion service/package/gem2rpm.yml
Expand Up @@ -38,7 +38,7 @@
Requires: yast2-iscsi-client >= 4.5.7
Requires: yast2-network
Requires: yast2-proxy
Requires: yast2-storage-ng >= 5.0.10
Requires: yast2-storage-ng >= 5.0.12
Requires: yast2-users
%ifarch s390 s390x
Requires: yast2-s390 >= 4.6.4
Expand Down
6 changes: 6 additions & 0 deletions service/package/rubygem-agama-yast.changes
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Thu Apr 18 08:46:06 UTC 2024 - Ladislav Slezák <lslezak@suse.com>

- Display encryption status in the storage result
(gh#openSUSE/agama#1155)

-------------------------------------------------------------------
Wed Apr 10 11:35:53 UTC 2024 - Ladislav Slezák <lslezak@suse.com>

Expand Down
Expand Up @@ -46,7 +46,9 @@

describe "#device_description" do
before do
allow(Y2Storage::DeviceDescription).to receive(:new).with(device).and_return(description)
allow(Y2Storage::DeviceDescription).to receive(:new)
.with(device, include_encryption: true)
.and_return(description)
end

let(:description) { instance_double(Y2Storage::DeviceDescription, to_s: "test") }
Expand Down

0 comments on commit 85c0ed5

Please sign in to comment.