Skip to content

Commit

Permalink
Run the Rubocop CI check only when a Ruby file is changed
Browse files Browse the repository at this point in the history
This avoids running Rubocop when it is not needed
  • Loading branch information
lslezak committed Aug 9, 2023
1 parent 4df4c55 commit a325f14
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 23 deletions.
54 changes: 54 additions & 0 deletions .github/workflows/ci-rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: "CI - Rubocop"

on:
push:
paths:
# NOTE: GitHub Actions do not allow using YAML references, the same path
# list is used below for the pull request event. Keep both lists in sync!!

# this file as well
- .github/workflows/ci-rubocop.yml
# Rubocop configuration
- service/.rubocop.yml
# all Ruby files
- service/Gemfile
- service/bin/agamactl
- service/**.rb

pull_request:
paths:
# NOTE: GitHub Actions do not allow using YAML references, the same path
# list is used above for the push event. Keep both lists in sync!!

# this file as well
- .github/workflows/ci-rubocop.yml
# Rubocop configuration
- service/.rubocop.yml
# all Ruby files
- service/Gemfile
- service/bin/agamactl
- service/**.rb

jobs:
rubocop:
runs-on: ubuntu-latest

defaults:
run:
working-directory: ./service

strategy:
fail-fast: false
matrix:
distro: [ "leap_latest" ]

container:
image: registry.opensuse.org/yast/head/containers_leap_latest${{matrix.distro}}/yast-ruby

steps:

- name: Git Checkout
uses: actions/checkout@v3

- name: Rubocop
run: /usr/bin/rubocop.*-1.24.1
23 changes: 0 additions & 23 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,29 +98,6 @@ jobs:
flag-name: backend
parallel: true

ruby_linter:
runs-on: ubuntu-latest

defaults:
run:
working-directory: ./service

strategy:
fail-fast: false
matrix:
distro: [ "leap_latest" ]

container:
image: registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby

steps:

- name: Git Checkout
uses: actions/checkout@v3

- name: Rubocop
run: /usr/bin/rubocop.*-1.24.1

ruby_doc:
runs-on: ubuntu-latest
env:
Expand Down

0 comments on commit a325f14

Please sign in to comment.