Skip to content

Commit

Permalink
[web] Drop intrusive warning shown in the storage proposal page (#1048)
Browse files Browse the repository at this point in the history
Since the Agama UI's regular workflow is to keep the system unchanged until installation begins, warning users about it is actually not needed. Thus, we agreed to use these intrusive warnings only in cases when/where Agama will take immediate action.
  • Loading branch information
dgdavid committed Feb 22, 2024
2 parents 202ae44 + 166aa9e commit e302716
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
6 changes: 6 additions & 0 deletions web/package/cockpit-agama.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Wed Feb 21 17:40:01 UTC 2024 - David Diaz <dgonzalez@suse.com>

- Stop rendering a warning at the top of storage page
(gh#openSUSE/agama#1048).

-------------------------------------------------------------------
Tue Feb 20 13:13:51 UTC 2024 - José Iván López González <jlopez@suse.com>

Expand Down
7 changes: 0 additions & 7 deletions web/src/components/storage/ProposalPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@
*/

import React, { useCallback, useReducer, useEffect } from "react";
import { Alert } from "@patternfly/react-core";

import { _ } from "~/i18n";
import { useInstallerClient } from "~/context/installer";
import { toValidationError, useCancellablePromise } from "~/utils";
import { Icon } from "~/components/layout";
import { Page } from "~/components/core";
import {
ProposalActionsSection,
Expand Down Expand Up @@ -210,11 +208,6 @@ export default function ProposalPage() {

return (
<>
<Alert
isInline
customIcon={<Icon name="info" size="xxs" />}
title={_("Devices will not be modified until installation starts.")}
/>
<ProposalSettingsSection
availableDevices={state.availableDevices}
volumeTemplates={usefulTemplates()}
Expand Down
6 changes: 0 additions & 6 deletions web/src/components/storage/ProposalPage.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ it("loads the proposal data", async () => {
await screen.findByText(/\/dev\/vda/);
});

it("renders a warning about modified devices", async () => {
installerRender(<ProposalPage />);

await screen.findByText(/Devices will not be modified/);
});

it("renders the settings, find space and actions sections", async () => {
installerRender(<ProposalPage />);

Expand Down

0 comments on commit e302716

Please sign in to comment.