Merge pull request #825 from openSUSE/fix-installation-finished

Display the "InstallationFinished" again
openSUSE · Oct 27, 2023 · eec3080 · eec3080
2 parents ff4fc26 + 98de4af
commit eec3080
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/web/package/cockpit-agama.changes b/web/package/cockpit-agama.changes
@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Fri Oct 27 10:25:46 UTC 2023 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>
+
+- Display the "Congratulations" message at the end of the
+  installation again (gh#openSUSE/agama#825).
+
 -------------------------------------------------------------------
 Thu Oct 26 16:07:02 UTC 2023 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>
 

diff --git a/web/src/App.jsx b/web/src/App.jsx
@@ -97,7 +97,7 @@ function App() {
     }
 
     if (phase === INSTALL) {
-      return <Installation />;
+      return <Installation status={status} />;
     }
 
     return <Outlet />;

diff --git a/web/src/components/core/Installation.jsx b/web/src/components/core/Installation.jsx
@@ -19,19 +19,11 @@
  * find current contact information at www.suse.com.
  */
 
-import React, { useEffect, useState } from "react";
-import { useInstallerClient } from "~/context/installer";
+import React from "react";
 import { InstallationProgress, InstallationFinished } from "~/components/core";
 import { IDLE } from "~/client/status";
 
-function Installation() {
-  const client = useInstallerClient();
-  const [status, setStatus] = useState(undefined);
-
-  useEffect(() =>
-    client.manager.onStatusChange(setStatus), [client.manager]
-  );
-
+function Installation({ status }) {
   return (status === IDLE) ? <InstallationFinished /> : <InstallationProgress />;
 }