-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Cockpit starter-kit webpack sync #413
Conversation
By default, webpack does not clean up dist/, so when you e.g. touch the code and rebuild with `NODE_ENV=devel`, the old compressed assets from a previous `production` build were left in place, and cockpit could serve the old wrong ones. Enable the `clean` output option to fix this [1]. Also force the rewrite of all files with `compareBeforeEmit: false`, so that the time stamps actually get updated on a webpack run. This fixes `make` rules and unnecessary rebuilds when nothing changed. Fixes #563 [1] https://webpack.js.org/configuration/output/#outputclean
Include CSS linting by default for our CSS/SCSS files, originally introduced in cockpit. The stylelint configuration is copied from 760a4628282e02fbcef3.
gap: var(--spacer-small); | ||
} | ||
|
||
section > svg { | ||
grid-aread: icon; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice linter catch around here 😅
ef20fe3
to
e5fcdde
Compare
It is a good idea to keep this stuff in sync. IMHO, we should add the style linter to our CI workflow. |
Done. Thanks for remembering it. |
Agree. But what do you think about cockpit-project/starter-kit@b3a9565? Does it look needed for you? |
Problem
Not a problem, but a suggestion: to keep our webpack config file in sync with the Cockpit Starter Kit counterpart as much as possible.
At this moment, we're three commits behind, namely:
Solution
To apply them
Pending
Not sure if the second one (build: don't move pkg/lib/ to src/lib/) proceeds here
Testing