Rename D-Installer to Agama #507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
agama
branch
2 times, most recently
from
97042bc
to
f1ed0b3
Compare
mvidner
requested changes
Mar 29, 2023
| @@ -54,7 +54,7 @@ def commit | |||
| end | |||
|
|
|||
| def current_installation_phase | |||
| dbus_phase = dbus_object["org.opensuse.DInstaller.Manager1"]["CurrentInstallationPhase"] | |||
| dbus_phase = dbus_object["org.opensuse.Agama1.Manager"]["CurrentInstallationPhase"] | |||
There was a problem hiding this comment.
watch out, the autorename did not work right here
it should be Agama.Manager1 for consistency with the other interfaces
There was a problem hiding this comment.
Not exactly. We have a root service, which is called org.opensuse.Agama1. Manager belongs to that service. We might consider renaming the service in the future, but I would keep it as It is by now.
Thanks for checking the changes!
mvidner
reviewed
Mar 29, 2023
| .DInstaller.Storage1.DASD.Format | ||
| .Agama1.ServiceStatus | ||
| .Agama1.Progress | ||
| .Agama1.Validation |
There was a problem hiding this comment.
also these 3, I believe we want .Agama.Foo1
There was a problem hiding this comment.
Not really, the idea is to have the version number in the service name.
mvidner
reviewed
Mar 29, 2023
| @@ -138,7 +138,7 @@ def safe_run(&block) | |||
| end | |||
|
|
|||
| def busy_error | |||
| ::DBus.error("org.opensuse.DInstaller.Error.Busy") | |||
| ::DBus.error("org.opensuse.Agama1.Error.Busy") | |||
There was a problem hiding this comment.
Suggested change
| ::DBus.error("org.opensuse.Agama1.Error.Busy") | |
| ::DBus.error("org.opensuse.Agama.Error1.Busy") |
There was a problem hiding this comment.
The same that the rest.
This was referenced Mar 30, 2023
|
Closed in favor of #509. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D-Installer is now Agama. So let's try to rename everything to the new name.