Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge root user settings #573

Merged
merged 2 commits into from May 11, 2023
Merged

Merge root user settings #573

merged 2 commits into from May 11, 2023

Conversation

imobachgs
Copy link
Member

@imobachgs imobachgs commented May 11, 2023 •
edited

Problem

Root user settings are not imported when reading them from a Jsonnet file.

Solution

Merge the root user settings. That kind of problem should go away when we generalize agama-derive to merge non-scalar fields too.

Testing

  • Added a new unit test
  • Manually tested

@coveralls
Copy link

coveralls commented May 11, 2023 •
edited

Pull Request Test Coverage Report for Build 4947184153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.755%
Totals Coverage Status
Change from base Build 4945630007: 0.0%
Covered Lines: 5039
Relevant Lines: 6502
💛 - Coveralls

joseivanlopez
joseivanlopez approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 73287f9 into master May 11, 2023
14 checks passed
@imobachgs imobachgs deleted the fix-users-import branch May 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imobachgs @coveralls @joseivanlopez