Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cargo only when it is missing #609

Merged
merged 2 commits into from Jun 7, 2023
Merged

Conversation

imobachgs
Copy link
Member

@imobachgs imobachgs commented Jun 7, 2023

Problem

If you install your Rust toolchain using rustup, running the setup-service.sh will fail with the following error:

Problem: the installed rustup-1.25.2~0-4.1.x86_64 conflicts with 'rust+cargo' provided by the to be installed cargo-1.69.0-1.1.x86_64
 Solution 1: deinstallation of rustup-1.25.2~0-4.1.x86_64
 Solution 2: do not install cargo-1.69.0-1.1.x86_64

Solution

Do not install cargo unless it is missing.

@coveralls
Copy link

coveralls commented Jun 7, 2023

Pull Request Test Coverage Report for Build 5197970484

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.686%

Totals Coverage Status
Change from base Build 5173879017: 0.0%
Covered Lines: 5396
Relevant Lines: 6890

💛 - Coveralls

setup-service.sh Outdated Show resolved Hide resolved
Co-authored-by: Josef Reidinger <jreidinger@suse.cz>
@imobachgs imobachgs merged commit 09bdba1 into master Jun 7, 2023
12 checks passed
@imobachgs imobachgs deleted the install-cargo-when-missing branch June 7, 2023 08:58
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants