[web] Drop heigh prop from Popup component #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reverting behavior introduced at 8b8de4c. Now we think that having scroll in Popups when there is room from them to grow is worst than a dialog changing its size for adapting to the content changes.
Pull Request Test Coverage Report for Build 5257579685
💛 - Coveralls |
And limit the width of nodes using this CSS class too. NOTE: not using "full-size" name instead because is already took.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes a change in its content causes a modal dialog to have scroll, even when the viewport is big enough to allow the dialog to grow and avoid the scrollbars.
This happens because Agama limits dialog height via the Popup/height prop since 8b8de4c.
In order to keep the dialog visually stable, we intentionally prevent the dialog from changing size as content changes. However, turned out that actually it is worse as it is now than just giving it the freedom to adapt to the content as long as the viewport height permits it.
Solution
Drop and stop using the
Popup/heightprop and use only thelargeCSS class when is need to force it to occupy as much size as possible.Testing
Screenshots
N/A.
Reviewers: Please, give it a shot by your self if you want to check the behavior.