Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zFCP UI #634

Merged
merged 7 commits into from Jul 4, 2023
Merged

zFCP UI #634

merged 7 commits into from Jul 4, 2023

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jun 20, 2023

Problem

Agama already provides a D-Bus API for managing zFCP devices, see #594 and #626. But there is no UI yet for configuring zFCP.

Solution

Add a new page for managing zFCP.

Requires yast/yast-s390#107.

Note: The target of this PR is the zfcp feature branch.

Testing

  • Added unit test
  • Tested manually

Screenshots

Show/Hide

localhost_8080_ (5)

localhost_8080_ (6)

localhost_8080_ (10)

localhost_8080_ (9)

localhost_8080_ (8)

localhost_8080_ (11)

@coveralls
Copy link

coveralls commented Jun 30, 2023

Coverage Status

coverage: 72.829% (+0.1%) from 72.709% when pulling fa85396 on joseivanlopez:zfcp-ui into f00bf3c on openSUSE:zfcp.

@joseivanlopez joseivanlopez force-pushed the zfcp-ui branch 2 times, most recently from 98f2480 to 76e8ce5 Compare June 30, 2023 15:12
@joseivanlopez joseivanlopez marked this pull request as ready for review July 3, 2023 10:25
Copy link
Member

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thanks! (I have not tried it by myself, but I know you did).

web/src/components/storage/ZFCPPage.jsx Outdated Show resolved Hide resolved
web/src/components/storage/ZFCPPage.jsx Show resolved Hide resolved
- Disks are activated and deactivated, but they cannot change.
- Note that cockpit emits a change signal when a proxy is created,
  but we do not need to handle it.
- This avoids multiple refreshes when there are a lot of disks.
- onValidate is removed because there is no need to validate the
  form data.
@joseivanlopez joseivanlopez merged commit 80efefe into openSUSE:zfcp Jul 4, 2023
7 checks passed
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants