Use the sprintf-js library instead of format-util #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also supports more formatting attributes like %2$s
lslezak
commented
Sep 5, 2023
| volume.sizeRelevantVolumes.join(_(", ")))); | ||
| conditions.push(sprintf(_("the presence of the file system for %s"), | ||
| // TRANSLATORS: conjunction for merging two list items | ||
| volume.sizeRelevantVolumes.join(_(", ")))); |
There was a problem hiding this comment.
Note: This strange indentation is required by eslint, I guess it is a buggy behavior...
imobachgs
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
format-utillibrary for formatting strings, but that is too simple%sor%dformats and does not support more complex cases like changing the order of arguments (%2$s) which might be needed in translationsSolution