[web] Wait until the logs path is resolved #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a a "protocol-error" raised by the CockpitChannel because of a "missing path option for fread channel". See #697
imobachgs
reviewed
Sep 11, 2023
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
imobachgs
approved these changes
Sep 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The download logs action on the web UI stop working. Instead of prompt the download, it crashes because of a
missing "path" option for fsread channel.Solution
Wait until the path promise is resolved before continue at
agama/web/src/client/manager.js
Line 89 in 0077885
It closes #697.
Testing