Destination option for agama logs store

[mchf]

Problem

When storing logs during installation it would be nice to be able to define destination path

Solution

added an option for agama logs store

Testing

• Tested manually

Screenshots

TODO: add one

[coveralls]

coverage: 65.578% (-0.09%) from 65.669%
when pulling d7aa245 on logs_store_dest
into 9e62e88 on master.

[imobachgs]

I would work a little on simplifying the parse_dest function. Beware, I have not tested my suggestions, so take them with a grain of salt 😉. Perhaps you should write a small unit test...

[imobachgs]

What if /tmp/agama_logs is already a directory? What if tomorrow we decide to change the default value? I would run the same checks whether it is the default or a value from the user.

This way, we could drop the match and save some nesting:

let mut buff = dest.unwrap_or(PathBuf::from(DEFAULT_RESULT));
let path = buff.as_path();

[imobachgs]

BTW, why not buffer instead of buff? We are just saving two letters :-)

[mchf]

if /tmp/agama_logs is already directory, then you will end up with /tmp/agama_logs.tar.bzip2 archive.

[mchf]

regarding buff`` well ... just matter of habit as i have been using buff```` and dest since I was at school, so it is kind of convention for me ;-) It is even used in man pages of such tools like ```cp```, ```rsync```, e.g. ```rsync``` defines its usage as ```rsync [OPTION...] SRC... [DEST]``` even in some options like ```--copy-dest=DIR```.

However, I don't have problem to extend it. It definitely is not stopper for me ;-)

[imobachgs]

Not even for me, I was curious especially about the "buff" case :-)

[imobachgs]

About the /tmp/agama_logs, my point is that I would run the same checks in both cases. And in that case, you could save the match statement (too much nesting for my taste). Anyway, I am not going to block the approval. Please, fix the conflict in the changes file.

[imobachgs]

I have clarified what I meant about the checks of /tmp/agama_logs.

[imobachgs]

About the /tmp/agama_logs, my point is that I would run the same checks in both cases. And in that case, you could save the match statement (too much nesting for my taste). Anyway, I am not going to block the approval. Please, fix the conflict in the changes file.

[mchf]

I have clarified what I meant about the checks of /tmp/agama_logs.

I got it ... I'm just testing it. Just used an opportunity and cleaned even another part.