New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide automatic priority update based on SLO requirements #41
Open
b10n1k
wants to merge
1
commit into
openSUSE:main
Choose a base branch
from
b10n1k:slo_auto_second_reminder
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okurz
requested changes
Apr 21, 2024
perlpunk
requested changes
Apr 21, 2024
b10n1k
force-pushed
the
slo_auto_second_reminder
branch
from
April 22, 2024 20:21
c795ff1
to
1519a4b
Compare
okurz
reviewed
Apr 23, 2024
b10n1k
force-pushed
the
slo_auto_second_reminder
branch
from
April 23, 2024 11:12
1519a4b
to
8180bfe
Compare
This PR adds automatic priority updates once the issues have already a reminder. Not action is taken for Low priority. Code is moved around to avoid redundant API requests. Test code could be also improved but i thought that it wont be a big problem for now. Signed-off-by: ybonatakis <ybonatakis@suse.com>
b10n1k
force-pushed
the
slo_auto_second_reminder
branch
from
April 24, 2024 06:44
8180bfe
to
474691f
Compare
okurz
approved these changes
Apr 25, 2024
kalikiana
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the unresolved points, and all of them were addressed from what I can tell.
Also looks sensible to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic priority updates once the issues have already a reminder. Not action is taken for Low priority. Code is moved around to avoid redundant API requests. Test code could be also improved but i thought that it wont be a big problem for now.
https://progress.opensuse.org/issues/119176