Include link to wiki in the second slo action #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Martchus
reviewed
May 14, 2024
okurz
reviewed
May 14, 2024
b10n1k
force-pushed
the
slo_amends
branch
2 times, most recently
from
edf9a77
to
2edc469
Compare
Use reminder_text and extend it with the expected comment to describe the action of the second reminder. The reason of the rewording is to make obvious that both reminders belong together. `msg` variable is moved outside of the individual functions which perform the reminder to avoid duplication. https://progress.opensuse.org/issues/119176#note-23 Signed-off-by: ybonatakis <ybonatakis@suse.com>
okurz
reviewed
May 16, 2024
|
feels like you overlooked my question in #52 (review) . can you answer that please? |
I havent run it but the changes should just make the comment exactly as we agree |
okurz
approved these changes
May 16, 2024
kalikiana
approved these changes
May 16, 2024
perlpunk
reviewed
May 16, 2024
| slo_priorities[priority_current]["next_priority"]["name"], | ||
| poo_id)) | ||
| url = "{}/{}.json".format(data["web"], poo_id) | ||
| msg = " ".join(update_slo_text.format( |
There was a problem hiding this comment.
If I execute this I think it's not what we want :D
>>> update_slo_text = "The ticket will be set to the next lower priority **{priority}**."
>>> msg = " ".join(update_slo_text.format(priority=23))
>>> msg
'T h e t i c k e t w i l l b e s e t t o t h e n e x t l o w e r p r i o r i t y * * 2 3 * * .'
There was a problem hiding this comment.
And @b10n1k please see if you can add test coverage - since I mistakenly thought this was covered, which is why I thought it must still work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://progress.opensuse.org/issues/119176#note-23