brp-25-symlink: do not relink /etc/os-release #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mounting a disk and inspecting "/etc/os-release" should give the information of the mounted volume, not of the host drive. https://bugzilla.opensuse.org/show_bug.cgi?id=1028408
dirkmueller
reviewed
Jun 1, 2017
| @@ -143,6 +143,8 @@ do | |||
| continue;; | |||
| /sbin/init,*) # don't create absolute symlink for /sbin/init | |||
| continue;; | |||
| /etc/os-release,*) # don't create absolute symlink for /etc/os-release (boo#1028408). | |||
There was a problem hiding this comment.
Why the '.*. suffix? There is only one file..
There was a problem hiding this comment.
This is in a case link,linkdest; link is /etc/os-release, linkdest can be either /usr/lib/os-releasse or ../usr/lib/os-release...
In any case, just /etc/os-release would not match the case statement
There was a problem hiding this comment.
Oh, and that's why it is comma star, not dor star
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mounting a disk and inspecting "/etc/os-release" should give the information
of the mounted volume, not of the host drive.
https://bugzilla.opensuse.org/show_bug.cgi?id=1028408